Skip to content

Workflows create batch overload - #7272

Merged
Naapperas merged 2 commits into
mainfrom
workflows-create-batch-overload
Oct 1, 2026
Merged

Naapperas merged 2 commits into
mainfrom
workflows-create-batch-overload

Conversation

@Naapperas

Copy link
Copy Markdown
Contributor

Adds an overload to the createBatch method in the Workflows binding, reflecting the new V2 API we are releasing for this method.

@Naapperas
Naapperas requested review from a team as code owners September 8, 2026 10:09
@Naapperas
Naapperas requested a review from penalosa September 8, 2026 10:09
@ask-bonk

ask-bonk Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Since last review: 2 resolved, 0 still open, 0 new.
LGTM!

Specialist findings not posted (1)
  • tests#1 [WARNING] src/cloudflare/internal/workflows.d.ts:54: The newly documented legacy-array behavior (failed creations are omitted rather than reported) has no regression test. The only array-form test uses successful IDs, and the mock's array branch returns… — The legacy array wrapper path is unchanged and delegates duplicate-ID behavior to the upstream service; the new mock behavior is not code under test for that contract.

Reviewed commit: 3ae44269 · github run

@pombosilva

Copy link
Copy Markdown
Contributor

LGTM from the Workflows team

@Naapperas
Naapperas force-pushed the workflows-create-batch-overload branch from 8477464 to 8faf87f Compare September 8, 2026 11:47

@penalosa penalosa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping from a types perspective (this still needs a runtime review).

Do you have a draft change ready to add this to Miniflare?

@Naapperas

Naapperas commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Stamping from a types perspective (this still needs a runtime review).

Do you have a draft change ready to add this to Miniflare?

Not yet: was planning on doing that after this went in but no reason to not do it at the same time. On it

cloudflare/workers-sdk#15777

@Naapperas
Naapperas force-pushed the workflows-create-batch-overload branch from e660ad4 to 081807f Compare September 30, 2026 13:16
Comment thread src/cloudflare/internal/test/workflows/workflows-api-test.js
Comment thread types/test/types/rpc.ts
@Naapperas
Naapperas force-pushed the workflows-create-batch-overload branch from 081807f to 3ae4426 Compare September 30, 2026 17:32
@Naapperas
Naapperas merged commit 00462aa into main Oct 1, 2026
32 checks passed
@Naapperas
Naapperas deleted the workflows-create-batch-overload branch October 1, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants